Stop parenthesizing context managers on Python 3.9 #4488
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This feels not worth it. We'd cause churn on projects that already run on 3.9 only. I'd rather stick with the new syntax only at this point. |
Makes sense. The way it's implemented it doesn't actually downgrade already parenthesized context managers, if I remember correctly. Though that's obviously a bug that could maybe be treated as a feature. |
|
Thanks, but I'm going to reject this, especially since we've already released this style for a long time. Parenthesized context managers realistically work fine in Python 3.9; it's unlikely that anybody is actively using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Discovered in python-trio/trio#3106 (comment), black is parenthesizing context managers for Python 3.9 despite that only officially landing in 3.10.
This isn't actually much of an issue as CPython 3.9 allows it and I assume PyPy does too, but it could technically be an issue and does mess things up with
-X oldparseron 3.9.Checklist - did you ...
CHANGES.mdif necessary?